Remove apparently useless next clause in #embedded_params causing method to return nil #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I actually have this fixed in an outstanding PR #262 sorry you ran into the bug. |
Contributor
Author
|
Aha, so it does! I also didn't know has_one serialization had been implemented by someone. Good stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where if a Her model, with a
has_manyassociation was built with an empty array for said association, that an error would be raised when#to_paramswas called on that object.The root of this problem was a
nextclause in the middle of an#inject(which causes the memo, formerly a hash, to becomenil).Regardless, it didn't seem to me that the
nextclause was accomplishing anything. An association skipped here because it was blank would still be included in the#to_paramsresult because it was being merged with the existing params. Removing the offending clause did not break any current specs.Also a ninja bug fix to use
#her_nearby_classto determine the class to call#include_root_in_json.